Conversation
mricher2000
force-pushed
the
EE-1082-OI-api-integration-update-braavos
branch
from
0b868e9 to
0c53d3f
Compare
mricher2000
changed the title
|
Are the OI API docs available either on Enverus site or somewhere in Confluence? Might not turn up in searches otherwise. Another possibility would be to update engineering docs/readme in this project to point to the google doc. |
dbaron-ft
left a comment
dbaron-ft
left a comment
There was a problem hiding this comment.
Left a couple questions.
Overall seems to be a mix of V1 and V2 in use at the same time, will these work together or does it require being all in on V2?
lib/open_invoice/entities/invoice.rb
Outdated
| class Invoice < Base | ||
| def index(opts = {}) | ||
| request(:get, "/supplier/#{supplier_uuid}/invoices/page", opts) | ||
| request(:get, "/#{OpenInvoice::Configure::VERSION_1}/supplier/#{supplier_uuid}/invoices/page", opts) |
There was a problem hiding this comment.
Why are these VERSION_1 whereas the base class is VERSION_2?
There was a problem hiding this comment.
Currently, some of Enverus's endpoints are on V1, and others are on V2 (currently only buyer & supplier).
| def buyer | ||
| @buyer ||= ::OpenInvoice::Entities::Buyer.new(supplier_uuid) | ||
| end | ||
|
|
There was a problem hiding this comment.
I've seen payment API used by Quickbooks integration. Is it possible that Braavos calls payment for all the integrations and might error out if this is removed? (just wondering if this should be a no-op rather than removed)
There was a problem hiding this comment.
hm it is possible @dbaron-ft. We have no payments in our braavos db where the source is oi, but looking at the data import job in braavos, there is a Generics::Importers::Base class that is used to imort payments.. which makes me think that maybe it tries to call this endpoint, even for OI?
I can leave it in & add a comment if that makes more sense?
There was a problem hiding this comment.
Some more context, I met with the OI API team last week and asked them about this endpoint. The investigated and confirmed that they have nothing on their end related to a payment endpoint currently in production or being developed
3 participants
Ticket
EE-1082
Changes
NOTE: a new base_url is also being used. It has been set for aux1 here
Note: the base_url will need to be updated for the other test environments & production
Enverus API docs here
Definition of Done